Feature/window-link #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome! I'd love to try using this :) |
|
wtf thats fantastic |
capaj
reviewed
Jan 19, 2024
| import { relay } from 'trpc-chrome/relay'; | ||
|
|
||
| const port = chrome.runtime.connect(); | ||
| relay(port, window); |
There was a problem hiding this comment.
@janek26 how do you use this relay?
Could you add like 2-3 line example?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Nice project, it's quite helpful especially combined with plasmo
Plasmo has the concept of "injecting into the main world" or how I like to call it "inpage scripts", which allow the extension to access the global objects used by a webpage, and escapes from the isolation content scripts usually run in.
https://docs.plasmo.com/framework/content-scripts#injecting-into-the-main-world
I added a link called
windowLinkand a relayer calledrelayto the package. Heavily inspired by how@plasmohq/messagingworks.In the process I found a bug with your chromeLink implementation for subscriptions, where the stop message would not be send (unsub before sending). Fixed that in the process, and covered that case with tests.